Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising a deprecation warning when included in modern Ember app (ironically) #51

Closed
lukemelia opened this issue Jul 11, 2018 · 4 comments

Comments

@lukemelia
Copy link

When booting up an Ember 3.x app that depends on this addon, the following deprecation warning is emitted:

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: [appname] -> ember-cli-deprecation-workflow -> ember-cli-babel

I looked into upgrading this addon, but it is unclear to me how monkey-patching deprecate would work with the new modules-based API.

@rwjblue
Copy link
Member

rwjblue commented Jul 11, 2018

I tried to do a basic round of updating in #47, but ran out of time and now it has languished 😢.

@rwjblue
Copy link
Member

rwjblue commented Jul 11, 2018

Though I'm not really sure why this addon would issue a deprecation, as we don't have ember-cli-babel as a dependency (its only a dev dep)...

@rwjblue
Copy link
Member

rwjblue commented Jul 11, 2018

Ahh it was fixed in #46 and released as 0.2.4.

@lukemelia - Can you confirm updating to latest fixes that deprecation?

@rwjblue
Copy link
Member

rwjblue commented Sep 26, 2018

Closing (I believe this was addressed in #46)...

@rwjblue rwjblue closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants