Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container is falsy build error with coverage enabled #283

Closed
Samsinite opened this issue Sep 1, 2020 · 5 comments
Closed

Container is falsy build error with coverage enabled #283

Samsinite opened this issue Sep 1, 2020 · 5 comments
Labels

Comments

@Samsinite
Copy link

Samsinite commented Sep 1, 2020

Hi, thanks for the addon!

I'm on 1.0.0, using ember/ember-cli 3.20 (this was not an issue with ember-cli 3.16), and am getting a weird build error with coverage enable:

Build Error (broccoli-persistent-filter:Babel > [Babel: app-ember]) in app-ember/controllers/roles/attorneys.js

/Users/samueljclopton/workspace/clever-case/app-ember/app-ember/controllers/roles/attorneys.js: Container is falsy

This file is actually at /Users/samueljclopton/workspace/clever-case/app-ember/controllers/roles/attorneys.js so it appears that the coverage tool is messing up the file path.

The test build works fine with coverage disabled. Had the same error as well using the previous beta.

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 1, 2020

Some more details over in ember-cli/babel-plugin-ember-modules-api-polyfill#112 (the actual issue is somewhere between that babel plugin and the istanbul one).

@rwjblue rwjblue added the bug label Sep 1, 2020
@rreckonerr
Copy link

Reporting the same issue.
Any workarounds as a temporary solution?

@kevvvnguyen
Copy link

Hey all, was wondering if there have been any updates on this issue?

@UkonnRa
Copy link

UkonnRa commented Jan 25, 2021

+1

@rwjblue
Copy link
Collaborator

rwjblue commented Feb 17, 2021

The issue was fixed in the downstream babel plugin (ember-cli/babel-plugin-ember-modules-api-polyfill#156). Make sure you update to the latest version of that plugin, and you should be good to go.

@rwjblue rwjblue closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants