Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 93 - null ref check #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue 93 - null ref check #94

wants to merge 1 commit into from

Conversation

raulgspan
Copy link

@raulgspan raulgspan commented Jul 30, 2022 •
edited
Loading

Fix issue 93 - null ref check

@Adverbly
Copy link

Is this a viable fix? The referenced issue mentions:

after video is removed from DOM

From what I understand, iframes fully reset their state when reparented, so it would likely be better to just re-initialize a new Player with a reference to the new iframe rather than trying to re-use the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iparm iparm iparm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accessing this.elem.contentWindow throws null reference exception after video is removed from DOM
3 participants
@raulgspan @Adverbly @iparm