From 1b11ee1474bb3a551b01fac9b3b8783d18214985 Mon Sep 17 00:00:00 2001 From: Kenneth Enevoldsen Date: Wed, 27 Mar 2024 12:47:13 +0100 Subject: [PATCH 1/2] ci: Added windows to test suite --- .github/workflows/test.yml | 5 ++++- docs/mmteb/points.md | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cb96788daa..99692eb56d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,7 +16,10 @@ jobs: matrix: os: [ubuntu-latest] #, macos-latest, windows-latest] python-version: ["3.8", "3.9", "3.10"] - + include: + # Add Windows with Python 3.8 only to avoid tests taking too long + - os: windows-latest + python-version: "3.8" # This allows a subsequently queued workflow run to interrupt previous runs concurrency: group: "${{ github.workflow }}-${{ matrix.python-version}}-${{ matrix.os }} @ ${{ github.ref }}" diff --git a/docs/mmteb/points.md b/docs/mmteb/points.md index b061d338da..70a2a7b49b 100644 --- a/docs/mmteb/points.md +++ b/docs/mmteb/points.md @@ -2,7 +2,7 @@ | GitHub | Total points | New dataset | New task | Dataset annotations | (Bug)fixes | Running Models | Review PR | Paper Writing | Ideation | Coordination | | ----------------- | ------------ | ----------- | -------- | ------------------- | ---------- | -------------- | -------- | -------------- | -------- | ------------- | -| KennethEnevoldsen | | 38 | | | | | | | | | +| KennethEnevoldsen | | 38 | | | 1 | | | | | | | x-tabdeveloping | | 2 | | | | | | | | | Note that coordination and ideation is not included in the total points, but is used to determine first and last authors. From 4c4c76edbfa7f31a40df801c335f396e691c77ca Mon Sep 17 00:00:00 2001 From: Kenneth Enevoldsen Date: Mon, 1 Apr 2024 11:52:35 +0200 Subject: [PATCH 2/2] feat: Changed to pytrec-eval-terrier to add support for windows installs --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 8149b8bc09..b05a711bf2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -35,7 +35,7 @@ dependencies = [ "torch", "tqdm", "rich", - "pytrec_eval", + "pytrec-eval-terrier>=0.5.6", "pydantic", "typing_extensions", "eval_type_backport",