Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation on windows #291

Closed
achibb opened this issue Mar 27, 2024 · 5 comments
Closed

Installation on windows #291

achibb opened this issue Mar 27, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@achibb
Copy link
Contributor

achibb commented Mar 27, 2024

Hi all!
I was trying to evaluate something / install mteb with pip install mteb and id id not seem to work on windows (colab however works).
Do you have any idea on how I could still evaluate my model "aari1995/German_Semantic_STS_V2" for German, e.g. on my GPU? :-)

Thank you!

` ValueError: path '/Users/cvangysel/Projects/pytrec_eval/trec_eval/convert_zscores.c' cannot be absolute
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> pytrec-eval

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
WARNING: Ignoring invalid distribution -rotobuf (c:\users\aaron\anaconda3\envs\nlu\lib\site-packages)
WARNING: Ignoring invalid distribution -rotobuf (c:\users\aaron\anaconda3\envs\nlu\lib\site-packages)
WARNING: Ignoring invalid distribution -rotobuf (c:\users\aaron\anaconda3\envs\nlu\lib\site-packages)
`

@KennethEnevoldsen
Copy link
Contributor

Thanks for reporting this @achibb, I sadly do not have access to a windows atm., but have added it to the test suite to make sure that it is validated not only now but going forward as well (#292).

Let us see how it goes.

One point that might cause an issue is the transition from a setup.py to a pyproject.toml for installation, which requires you to update your pip installation:

pip install pip --upgrade

@KennethEnevoldsen
Copy link
Contributor

Hmm seems like the issues stem from the pytrec_eval-package (as you also see). Seems like others have the same issue as well cvangysel/pytrec_eval#32 (comment)

@KennethEnevoldsen
Copy link
Contributor

@Muennighoff seems like pytrec_eval is not really developed anymore, it might be worth switching it out with something else?

@Muennighoff
Copy link
Contributor

@Muennighoff seems like pytrec_eval is not really developed anymore, it might be worth switching it out with something else?

Great point, fine with me to switch it out if scores match! Maybe we don't even need a package and can just add the metrics we use from it to https://github.com/embeddings-benchmark/mteb/blob/main/mteb/evaluation/evaluators/utils.py

@KennethEnevoldsen KennethEnevoldsen added the good first issue Good for newcomers label Mar 28, 2024
@KennethEnevoldsen
Copy link
Contributor

A solution to this issue was added in #292 so will close this but feel free to open if there is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants