feat: Added windows support by replacing pytrec-eval with pytrec-eval…

…-terrier (#292) * ci: Added windows to test suite * feat: Changed to pytrec-eval-terrier to add support for windows installs
embeddings-benchmark · Apr 1, 2024 · fc0e105 · fc0e105
1 parent 39d005b
commit fc0e105
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,10 @@ jobs:
       matrix:
         os: [ubuntu-latest] #, macos-latest, windows-latest]
         python-version: ["3.8", "3.9", "3.10"]
-
+        include:
+          # Add Windows with Python 3.8 only to avoid tests taking too long
+          - os: windows-latest
+            python-version: "3.8"
     # This allows a subsequently queued workflow run to interrupt previous runs
     concurrency:
       group: "${{ github.workflow }}-${{ matrix.python-version}}-${{ matrix.os }} @ ${{ github.ref }}"

diff --git a/docs/mmteb/points.md b/docs/mmteb/points.md
@@ -2,7 +2,7 @@
 
 | GitHub            | Total points | New dataset | New task | Dataset annotations | (Bug)fixes | Running Models | Review PR |  Paper Writing | Ideation | Coordination |
 | ----------------- | ------------ | ----------- | -------- | ------------------- | ---------- | -------------- |  -------- | -------------- | -------- | ------------- |
-| KennethEnevoldsen |              |   38        |          |                     |            |                |           |                |         |               |
+| KennethEnevoldsen |              |   38        |          |                     |         1  |                |           |                |         |               |
 | x-tabdeveloping   |              |    2        |          |                     |            |                |           |                |        |               |
 
 Note that coordination and ideation is not included in the total points, but is used to determine first and last authors. 

diff --git a/pyproject.toml b/pyproject.toml
@@ -35,7 +35,7 @@ dependencies = [
     "torch",
     "tqdm",
     "rich",
-    "pytrec_eval",
+    "pytrec-eval-terrier>=0.5.6",
     "pydantic",
     "typing_extensions",
     "eval_type_backport",