Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Eglot #2

Closed
jojojames opened this issue Aug 2, 2018 · 5 comments
Closed

Support for Eglot #2

jojojames opened this issue Aug 2, 2018 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed longterm

Comments

@jojojames
Copy link

Might be cool to decouple dap-mode from lsp-mode and support https://github.com/joaotavora/eglot too!

Thanks for the package. :)

@yyoncho yyoncho added the enhancement New feature or request label Aug 2, 2018
@yyoncho
Copy link
Member

yyoncho commented Aug 2, 2018

I will keep that in mind. Eglot does not work with Java JDT LS server so at this point there is no way to test it.

@yveszoundi
Copy link

It looks like Eglot now supports the Java JDT LS server, likely less options than lsp-java but maybe dap-mode could work with it.

@yyoncho
Copy link
Member

yyoncho commented Dec 14, 2018

@yveszoundi Given the fact I was promoted to member in lsp-mode, the fact that lsp-mode was redesigned and it now supports most(if not all) features of eglot out of the box(https://github.com/emacs-lsp/lsp-mode#whats-new-in-lspel) and much more, the fact that eglot is not interested in supporting extension methods brings this PR closer to rejecting or at least not addressing it in near future.

@yveszoundi
Copy link

Thanks @yyoncho, fair enough.

@yyoncho
Copy link
Member

yyoncho commented Oct 19, 2019

Closing as won't fix considering the amount of work in lsp-mode/dap-mode repo and the overhead that solving this PR will introduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed longterm
Projects
None yet
Development

No branches or pull requests

3 participants