-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Eglot #2
Comments
I will keep that in mind. Eglot does not work with Java JDT LS server so at this point there is no way to test it. |
It looks like Eglot now supports the Java JDT LS server, likely less options than |
@yveszoundi Given the fact I was promoted to member in lsp-mode, the fact that lsp-mode was redesigned and it now supports most(if not all) features of eglot out of the box(https://github.com/emacs-lsp/lsp-mode#whats-new-in-lspel) and much more, the fact that eglot is not interested in supporting extension methods brings this PR closer to rejecting or at least not addressing it in near future. |
Thanks @yyoncho, fair enough. |
Closing as won't fix considering the amount of work in lsp-mode/dap-mode repo and the overhead that solving this PR will introduce. |
Might be cool to decouple dap-mode from lsp-mode and support https://github.com/joaotavora/eglot too!
Thanks for the package. :)
The text was updated successfully, but these errors were encountered: