We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue There are hardcoded references to specific runtimes (airflow, kfp) in the frontend code. Couple of issues with this:
Grepping for kfp or airflow returns those hits:
kfp
airflow
packages/pipeline-editor/src/PipelineEditorWidget.tsx: pipelineRuntimeName === 'kfp' packages/pipeline-editor/src/PipelineService.tsx:export const KFP_SCHEMA = 'kfp'; packages/pipeline-editor/src/index.ts: runtime.name === 'kfp' ? 2 : runtime.name === 'airflow' ? 3 : 4 packages/pipeline-editor/src/index.ts: runtime.name === 'kfp' ? 31 : runtime.name === 'airflow' ? 32 : 33 packages/pipeline-editor/src/pipeline-hooks.ts: case 'kfp': packages/services/src/test/application.spec.ts: 'kfp', packages/ui-components/src/icons.tsx: name: 'elyra:kfp', packages/pipeline-editor/src/PipelineEditorWidget.tsx: airflowIcon packages/pipeline-editor/src/PipelineEditorWidget.tsx: : pipelineRuntimeName === 'airflow' packages/pipeline-editor/src/PipelineEditorWidget.tsx: ? airflowIcon packages/pipeline-editor/src/PipelineService.tsx: {response['platform'] == 'airflow' ? ( packages/pipeline-editor/src/RuntimesWidget.tsx: if (metadata.schema_name === 'airflow' && metadata_props) { packages/pipeline-editor/src/index.ts: runtime.name === 'kfp' ? 2 : runtime.name === 'airflow' ? 3 : 4 packages/pipeline-editor/src/index.ts: runtime.name === 'kfp' ? 31 : runtime.name === 'airflow' ? 32 : 33 packages/pipeline-editor/src/pipeline-hooks.ts: airflowIcon, packages/pipeline-editor/src/pipeline-hooks.ts: case 'airflow': packages/pipeline-editor/src/pipeline-hooks.ts: category.image = IconUtil.encode(airflowIcon); packages/pipeline-editor/src/pipeline-hooks.ts: const runtimeIcons = [kubeflowIcon, airflowIcon]; packages/services/src/test/application.spec.ts: 'airflow' packages/ui-components/src/icons.tsx:import airflowSvg from '../style/icons/airflow.svg'; packages/ui-components/src/icons.tsx:export const airflowIcon = new LabIcon({ packages/ui-components/src/icons.tsx: name: 'elyra:airflow', packages/ui-components/src/icons.tsx: svgstr: airflowSvg
Describe the solution you'd like Remove those hardcoded references. Frontend should be agnostic to the list of available runtimes.
Describe alternatives you've considered Adding even more hardcode refs?
The text was updated successfully, but these errors were encountered:
addressed by : #2135
Sorry, something went wrong.
No branches or pull requests
Issue
There are hardcoded references to specific runtimes (airflow, kfp) in the frontend code. Couple of issues with this:
Grepping for
kfp
orairflow
returns those hits:Describe the solution you'd like
Remove those hardcoded references. Frontend should be agnostic to the list of available runtimes.
Describe alternatives you've considered
Adding even more hardcode refs?
The text was updated successfully, but these errors were encountered: