Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for components and pipelines #1903

Closed
blublinsky opened this issue Jul 12, 2021 · 3 comments
Closed

Add parameters for components and pipelines #1903

blublinsky opened this issue Jul 12, 2021 · 3 comments
Labels
component:pipeline-editor pipeline editor component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines feedback:user kind:enhancement New feature or request platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime
Milestone

Comments

@blublinsky
Copy link

Is your feature request related to a problem? Please describe.
KFP pipelines allow to add parameters to components, for example:

# Writing bigger data
@func_to_container_op
def repeat_line(line: str, output_text_path: OutputPath(str), count: int = 10):
    '''Repeat the line specified number of times'''
    with open(output_text_path, 'w') as writer:
        for i in range(count):
            writer.write(line + '\n')


# Reading bigger data
@func_to_container_op
def print_text(text_path: InputPath()): # The "text" input is untyped so that any data can be printed
    '''Print text'''
    with open(text_path, 'r') as reader:
        for line in reader:
            print(line, end = '')

def print_repeating_lines_pipeline():
    repeat_lines_task = repeat_line(line='Hello', count=5000)
    print_text(repeat_lines_task.output) # Don't forget .output 

It would be great to add similar to Elyra as config parameters

Additionally KFP allows to pass parameters to pipeline itself

def caching_pipeline(seconds: float = 60):
    # All outputs of successfull executions are cached
    work_task = do_work_op(seconds)

Adding this capability to Elyra will be great as well.

@blublinsky blublinsky added the kind:enhancement New feature or request label Jul 12, 2021
@lresende lresende added component:pipeline-editor pipeline editor component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines and removed status:Needs Triage labels Jul 12, 2021
@lresende lresende self-assigned this Jul 12, 2021
@ptitzler
Copy link
Member

@ptitzler ptitzler added the platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime label Jul 12, 2021
@ptitzler
Copy link
Member

I created #1920 to reduce the scope of this feature request. Python function-based components are not yet supported.

@ptitzler
Copy link
Member

Delivered in #3053 and #3001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines feedback:user kind:enhancement New feature or request platform: pipeline-Kubeflow Related to usage of Kubeflow Pipelines as pipeline runtime
Projects
None yet
Development

No branches or pull requests

4 participants