Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server warnings #1888

Closed
karlaspuldaro opened this issue Jul 8, 2021 · 2 comments
Closed

Language server warnings #1888

karlaspuldaro opened this issue Jul 8, 2021 · 2 comments
Assignees
Labels
component:lsp Issues related to Component Server Protocol extension external:Upstream Depended on deliverables in other repos outside the elyra org
Milestone

Comments

@karlaspuldaro
Copy link
Member

karlaspuldaro commented Jul 8, 2021

Describe the issue
Upstream issue

Latest release of jupyterlab-lsp (v3.8.0 + jupyter-lsp 1.4.0) introduces new server warnings, logged when running jupyterlab, in the format:

Failed to validate commands from language server spec finder `x-language-server`: [<ValidationError: "None is not of type 'string'">]

for some of the language server specs defined here (See full list below)

Command Line Output
[W 2021-07-06 12:28:01.705 ServerApp] Failed to validate commands from language server spec finder `bash-language-server`:
    []
[W 2021-07-06 12:28:01.705 ServerApp] Failed to validate commands from language server spec finder `dockerfile-language-server-nodejs`:
    []
[W 2021-07-06 12:28:01.706 ServerApp] Failed to validate commands from language server spec finder `javascript-typescript-langserver`:
    []
[W 2021-07-06 12:28:01.708 ServerApp] Failed to validate commands from language server spec finder `pyright`:
    []
[W 2021-07-06 12:28:01.710 ServerApp] Failed to validate commands from language server spec finder `sql-language-server`:
    []
[W 2021-07-06 12:28:01.712 ServerApp] Failed to validate commands from language server spec finder `unified-language-server`:
    []
[W 2021-07-06 12:28:01.712 ServerApp] Failed to validate commands from language server spec finder `vscode-css-languageserver-bin`:
    []
[W 2021-07-06 12:28:01.713 ServerApp] Failed to validate commands from language server spec finder `vscode-html-languageserver-bin`:
    []
[W 2021-07-06 12:28:01.713 ServerApp] Failed to validate commands from language server spec finder `vscode-json-languageserver-bin`:
    []
[W 2021-07-06 12:28:01.714 ServerApp] Failed to validate commands from language server spec finder `yaml-language-server`:
    []

To Reproduce
Steps to reproduce the behavior:

  1. Run jupyter lab with the --debug flag and watch for warning logs on terminal

Expected behavior
No warnings logged for missing language servers

Context information

  • Elyra version: 3.0.0-dev
  • Jupyterlab-lsp version: 3.8.0
  • Jupyter-lsp vresion: 1.4.0
  • Operating system: macOS
@karlaspuldaro karlaspuldaro added external:Upstream Depended on deliverables in other repos outside the elyra org component:lsp Issues related to Component Server Protocol extension labels Jul 8, 2021
@karlaspuldaro karlaspuldaro self-assigned this Jul 8, 2021
@karlaspuldaro
Copy link
Member Author

Fixed in upstream by https://github.com/krassowski/jupyterlab-lsp/pull/645
Waiting for new package release before closing the issue here.

@lresende lresende added this to the 3.0.0 milestone Jul 20, 2021
@akchinSTC
Copy link
Member

Closing. Waiting for JL LSP release and this will get picked up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:lsp Issues related to Component Server Protocol extension external:Upstream Depended on deliverables in other repos outside the elyra org
Projects
None yet
Development

No branches or pull requests

3 participants