From d5caf9589a10a979b3241c7b85ca2cd895a533d6 Mon Sep 17 00:00:00 2001
From: Joshua Marner <biz@jmarner.com>
Date: Mon, 22 Apr 2024 17:14:36 -0500
Subject: [PATCH 1/3] Add a typed version of OneWaySeq

---
 src/Elmish.WPF/Binding.fs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/Elmish.WPF/Binding.fs b/src/Elmish.WPF/Binding.fs
index d3c07694..f74f4ba6 100644
--- a/src/Elmish.WPF/Binding.fs
+++ b/src/Elmish.WPF/Binding.fs
@@ -116,6 +116,13 @@ module Binding =
       OneWayToSource.id
       |> createBindingT
 
+
+  module OneWaySeqT =
+
+    let id itemEquals (getId: 'a -> 'id) : string -> Binding<_, 'msg, _> =
+      OneWaySeq.create itemEquals getId
+      |> createBindingT
+
   /// <summary>
   ///   Strongly-typed bindings that update both ways
   /// </summary>

From adf9c37aba67c5e9b678677d154703600b859eff Mon Sep 17 00:00:00 2001
From: Joshua Marner <biz@jmarner.com>
Date: Mon, 22 Apr 2024 17:15:04 -0500
Subject: [PATCH 2/3] Add example of OneWaySeqT

---
 src/Samples/SubModelStatic.Core/Program.fs | 13 ++++---
 src/Samples/SubModelStatic/Counter.xaml    | 41 +++++++++++++++++-----
 src/Samples/SubModelStatic/MainWindow.xaml |  2 +-
 3 files changed, 42 insertions(+), 14 deletions(-)

diff --git a/src/Samples/SubModelStatic.Core/Program.fs b/src/Samples/SubModelStatic.Core/Program.fs
index 297e7d08..c983a4eb 100644
--- a/src/Samples/SubModelStatic.Core/Program.fs
+++ b/src/Samples/SubModelStatic.Core/Program.fs
@@ -11,7 +11,8 @@ module Counter =
 
   type Model =
     { Count: int
-      StepSize: int }
+      StepSize: int
+      History: (int * int) list }
 
   type Msg =
     | Increment
@@ -21,14 +22,15 @@ module Counter =
 
   let init =
     { Count = 0
-      StepSize = 1 }
+      StepSize = 1
+      History = [] }
 
   let canReset = (<>) init
 
   let update msg m =
     match msg with
-    | Increment -> { m with Count = m.Count + m.StepSize }
-    | Decrement -> { m with Count = m.Count - m.StepSize }
+    | Increment -> { m with Count = m.Count + m.StepSize; History = (m.Count, m.History.Length) :: m.History }
+    | Decrement -> { m with Count = m.Count - m.StepSize; History = (m.Count, m.History.Length) :: m.History }
     | SetStepSize x -> { m with StepSize = x }
     | Reset -> init
 
@@ -41,7 +43,7 @@ type [<AllowNullLiteral>] CounterViewModel (args) =
     >> Binding.mapModel (fun (m: Counter.Model) -> m.StepSize)
     >> Binding.mapMsg Counter.Msg.SetStepSize
 
-  new() = CounterViewModel(Counter.init |> ViewModelArgs.simple)
+  new() = CounterViewModel({ Counter.init with History = [ (3,1); (0,0) ] } |> ViewModelArgs.simple)
 
   member _.StepSize
     with get() = base.Get() stepSizeBinding
@@ -50,6 +52,7 @@ type [<AllowNullLiteral>] CounterViewModel (args) =
   member _.Increment = base.Get() (Binding.CmdT.setAlways Counter.Increment)
   member _.Decrement = base.Get() (Binding.CmdT.setAlways Counter.Decrement)
   member _.Reset = base.Get() (Binding.CmdT.set Counter.canReset Counter.Reset)
+  member _.History = base.Get() (Binding.OneWaySeqT.id (=) snd >> Binding.mapModel (fun m -> m.History))
 
 
 module Clock =
diff --git a/src/Samples/SubModelStatic/Counter.xaml b/src/Samples/SubModelStatic/Counter.xaml
index 2fa11674..5551966d 100644
--- a/src/Samples/SubModelStatic/Counter.xaml
+++ b/src/Samples/SubModelStatic/Counter.xaml
@@ -6,12 +6,37 @@
              xmlns:vm="clr-namespace:Elmish.WPF.Samples.SubModelStatic;assembly=SubModelStatic.Core"
              mc:Ignorable="d"
              d:DataContext="{d:DesignInstance Type=vm:CounterViewModel, IsDesignTimeCreatable=True}">
-  <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Top">
-    <TextBlock Text="{Binding CounterValue, StringFormat='Counter value: {0}'}" Width="110" Margin="0,5,10,5" />
-    <Button Command="{Binding Decrement}" Content="-" Margin="0,5,10,5" Width="30" />
-    <Button Command="{Binding Increment}" Content="+" Margin="0,5,10,5" Width="30" />
-    <TextBlock Text="{Binding StepSize, StringFormat='Step size: {0}'}" Width="70" Margin="0,5,10,5" />
-    <Slider Value="{Binding StepSize}" TickFrequency="1" Maximum="10" Minimum="1" IsSnapToTickEnabled="True" Width="100" Margin="0,5,10,5" />
-    <Button Command="{Binding Reset}" Content="Reset" Margin="0,5,10,5" Width="50" />
-  </StackPanel>
+  <Grid>
+    <Grid.RowDefinitions>
+      <RowDefinition/>
+      <RowDefinition/>
+    </Grid.RowDefinitions>
+    <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Top">
+      <TextBlock Text="{Binding CounterValue, StringFormat='Counter value: {0}'}" Width="110" Margin="0,5,10,5" />
+      <Button Command="{Binding Decrement}" Content="-" Margin="0,5,10,5" Width="30" />
+      <Button Command="{Binding Increment}" Content="+" Margin="0,5,10,5" Width="30" />
+      <TextBlock Text="{Binding StepSize, StringFormat='Step size: {0}'}" Width="70" Margin="0,5,10,5" />
+      <Slider Value="{Binding StepSize}" TickFrequency="1" Maximum="10" Minimum="1" IsSnapToTickEnabled="True" Width="100" Margin="0,5,10,5" />
+      <Button Command="{Binding Reset}" Content="Reset" Margin="0,5,10,5" Width="50" />
+    </StackPanel>
+    <DockPanel Grid.Row="1" HorizontalAlignment="Stretch" VerticalAlignment="Top">
+      <TextBlock DockPanel.Dock="Left" Margin="0,5,10,5">History:</TextBlock>
+      <TextBlock Margin="2,5,2,5">
+        <Run Text="{Binding CounterValue, Mode=OneWay, StringFormat='({0},'}" />
+        <Run Text="{Binding History.Count, Mode=OneWay, StringFormat='{}{0})'}" />
+      </TextBlock>
+      <ItemsControl ItemsSource="{Binding History}">
+        <ItemsControl.ItemTemplate>
+          <DataTemplate>
+            <TextBlock Text="{Binding}" TextDecorations="Strikethrough" Margin="2,5,2,5" />
+          </DataTemplate>
+        </ItemsControl.ItemTemplate>
+        <ItemsControl.ItemsPanel>
+          <ItemsPanelTemplate>
+            <StackPanel Orientation="Horizontal"/>
+          </ItemsPanelTemplate>
+        </ItemsControl.ItemsPanel>
+      </ItemsControl>
+    </DockPanel>
+  </Grid>
 </UserControl>
diff --git a/src/Samples/SubModelStatic/MainWindow.xaml b/src/Samples/SubModelStatic/MainWindow.xaml
index 58672e81..e721778d 100644
--- a/src/Samples/SubModelStatic/MainWindow.xaml
+++ b/src/Samples/SubModelStatic/MainWindow.xaml
@@ -6,7 +6,7 @@
         xmlns:local="clr-namespace:Elmish.WPF.Samples.SubModelStatic"
         xmlns:vm="clr-namespace:Elmish.WPF.Samples.SubModelStatic;assembly=SubModelStatic.Core"
         Title="Sub-model"
-        Height="270"
+        Height="300"
         Width="500"
         WindowStartupLocation="CenterScreen"
         mc:Ignorable="d"

From 56d69d01968b7377e86dab77736c3d1f954c4c55 Mon Sep 17 00:00:00 2001
From: Joshua Marner <biz@jmarner.com>
Date: Mon, 22 Apr 2024 18:17:14 -0500
Subject: [PATCH 3/3] Add better documentation.

---
 src/Elmish.WPF/Binding.fs | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/src/Elmish.WPF/Binding.fs b/src/Elmish.WPF/Binding.fs
index f74f4ba6..ab30862e 100644
--- a/src/Elmish.WPF/Binding.fs
+++ b/src/Elmish.WPF/Binding.fs
@@ -116,13 +116,6 @@ module Binding =
       OneWayToSource.id
       |> createBindingT
 
-
-  module OneWaySeqT =
-
-    let id itemEquals (getId: 'a -> 'id) : string -> Binding<_, 'msg, _> =
-      OneWaySeq.create itemEquals getId
-      |> createBindingT
-
   /// <summary>
   ///   Strongly-typed bindings that update both ways
   /// </summary>
@@ -132,6 +125,22 @@ module Binding =
     let id<'a> : string -> Binding<'a, 'a, 'a> =
       TwoWay.id
       |> createBindingT
+      
+  /// <summary>
+  ///   The strongly-typed counterpart of <c>Binding.oneWaySeq</c> with parameter <c>getId</c>.
+  ///   Exposes an <c>ObservableCollection</c> of child items for binding.
+  ///   Allows a more efficient update than would be possible without using ids.
+  /// </summary>
+  module OneWaySeqT =
+
+    /// <summary>
+    /// Elemental instance of a OneWaySeqT binding
+    /// </summary>
+    /// <param name="itemEquals">Defines whether an item is "equal" and needs to be updated if the ids are the same</param>
+    /// <param name="getId">Unique identifier for each item in the list (for efficient updates).</param>
+    let id itemEquals (getId: 'a -> 'id) : string -> Binding<_, 'msg, _> =
+      OneWaySeq.create itemEquals getId
+      |> createBindingT
 
   /// <summary>
   ///   Strongly-typed bindings that dispatch messages from the view.