Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

PHP Warnings on FEE_Field_[FieldName] implementations of wrap() #310

Open
apotek opened this issue Mar 2, 2017 · 2 comments
Open

PHP Warnings on FEE_Field_[FieldName] implementations of wrap() #310

apotek opened this issue Mar 2, 2017 · 2 comments

Comments

@apotek
Copy link

apotek commented Mar 2, 2017

Expected behaviour and actual behaviour

Plugin works as expected, but generates a WARNING on every wordpress execution, targeting various fields. Some examples:

PHP Warning: Declaration of FEE_Field_Single_Title::wrap($title) should be compatible with FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

PHP Warning: Declaration of FEE_Field_Option::wrap($content, $key, $ui) should be compatible with FEE_Field_Base::wrap($content, $data) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

PHP Warning: Declaration of FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) should be compatible with FEE_Field_Base::wrap($content, $data) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

The signature of the base clase is different than the signature in the implemented class. This can lead to bugs, and given the name of the parameters, I would imagine there is a bug here, though I haven't experienced a behavior.

Steps to reproduce the problem

Load any wordpress page with front-end-editor plugin installed.

Specifications

  • Browser Name and Version: Any browser. Applies to any request to server whether using curl, or chrome, or firefox. Currently using curl.
  • WordPress Version: 4.7.2
  • Plugin Version: 2.3.1
  • Theme name/URL:

Error messages

PHP Warning: Declaration of FEE_Field_Single_Title::wrap($title) should be compatible with FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

@apotek apotek changed the title PHP Warning on FEE_Field_Option::wrap method signature PHP Warning on FEE_Field_[FieldName] implementations of wrap() Mar 2, 2017
@apotek apotek changed the title PHP Warning on FEE_Field_[FieldName] implementations of wrap() PHP Warnings on FEE_Field_[FieldName] implementations of wrap() Mar 2, 2017
@apotek
Copy link
Author

apotek commented Mar 2, 2017

Might point out I am using php 7.0

@1BJK903
Copy link

1BJK903 commented May 3, 2017

Have the same problem right now...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants