Tesla.Middleware.FollowRedirects causes Tesla.Middleware.Query to add query string multiple times

[praveenperera]

If you had both

plug Tesla.Middleware.Query [token: "secret"]
plug Tesla.Middleware.FollowRedirects

The ?token="secret" will be added multiple times, each time its redirect.

[teamon]

Looks like you're right:

defmodule GH334 do
  use Tesla

  plug Tesla.Middleware.Query, token: "secret"
  plug Tesla.Middleware.FollowRedirects
end

{:ok, env} = GH334.get("http://localhost:8888/redirect/4")
200 = env.status

docker run -p 8888:80  -e GUNICORN_CMD_ARGS="--capture-output --error-logfile - --access-logfile - --access-logformat '%(h)s %(t)s %(r)s %(s)s Host: %({Host}i)s}'" kennethreitz/httpbin

172.17.0.1 [19/Nov/2019:10:13:48 +0000] GET /redirect/4?token=secret HTTP/1.1 302 Host: localhost:8888}
172.17.0.1 [19/Nov/2019:10:13:48 +0000] GET /relative-redirect/3?token=secret HTTP/1.1 302 Host: localhost:8888}
172.17.0.1 [19/Nov/2019:10:13:48 +0000] GET /relative-redirect/2?token=secret HTTP/1.1 302 Host: localhost:8888}
172.17.0.1 [19/Nov/2019:10:13:48 +0000] GET /relative-redirect/1?token=secret HTTP/1.1 302 Host: localhost:8888}
172.17.0.1 [19/Nov/2019:10:13:48 +0000] GET /get?token=secret HTTP/1.1 200 Host: localhost:8888}

[teamon]

Nice catch @praveenperera! Fixed in 3195e25