From c0c6d0ef733d6e8f6f421f602447585664ae57b5 Mon Sep 17 00:00:00 2001 From: Michael Heilmann Date: Thu, 21 Dec 2023 10:27:12 -0500 Subject: [PATCH] linting fixes (#16) --- lib/grpc_reflection/dynamic_supervisor.ex | 2 +- lib/grpc_reflection/service/agent.ex | 16 +++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/grpc_reflection/dynamic_supervisor.ex b/lib/grpc_reflection/dynamic_supervisor.ex index 386615d..d9f6b8f 100644 --- a/lib/grpc_reflection/dynamic_supervisor.ex +++ b/lib/grpc_reflection/dynamic_supervisor.ex @@ -1,6 +1,6 @@ defmodule GrpcReflection.DynamicSupervisor do @moduledoc false - + use DynamicSupervisor def start_link(init_arg) do diff --git a/lib/grpc_reflection/service/agent.ex b/lib/grpc_reflection/service/agent.ex index d8682fd..f8ae8fb 100644 --- a/lib/grpc_reflection/service/agent.ex +++ b/lib/grpc_reflection/service/agent.ex @@ -11,10 +11,11 @@ defmodule GrpcReflection.Service.Agent do defstruct services: [], files: %{}, symbols: %{} @type descriptor_t :: GrpcReflection.descriptor_t() - @type t :: %{ - required(:services) => list(module()), - required(:files) => %{optional(binary()) => descriptor_t()}, - required(:symbols) => %{optional(binary()) => descriptor_t()} + @type cfg_t :: {atom(), list(atom)} + @type t :: %__MODULE__{ + services: list(module()), + files: %{optional(binary()) => descriptor_t()}, + symbols: %{optional(binary()) => descriptor_t()} } def start_link(_, opts) do @@ -31,24 +32,25 @@ defmodule GrpcReflection.Service.Agent do end end - @spec list_services(atom()) :: list(binary) + @spec list_services(cfg_t()) :: list(binary) def list_services(cfg) do name = start_agent_on_first_call(cfg) Agent.get(name, &Lookup.lookup_services/1) end - @spec get_by_symbol(atom(), binary()) :: {:ok, descriptor_t()} | {:error, binary} + @spec get_by_symbol(cfg_t(), binary()) :: {:ok, descriptor_t()} | {:error, binary} def get_by_symbol(cfg, symbol) do name = start_agent_on_first_call(cfg) Agent.get(name, &Lookup.lookup_symbol(symbol, &1)) end - @spec get_by_filename(atom(), binary()) :: {:ok, descriptor_t()} | {:error, binary} + @spec get_by_filename(cfg_t(), binary()) :: {:ok, descriptor_t()} | {:error, binary} def get_by_filename(cfg, filename) do name = start_agent_on_first_call(cfg) Agent.get(name, &Lookup.lookup_filename(filename, &1)) end + @spec put_state(cfg_t(), t()) :: :ok def put_state(cfg, %__MODULE__{} = state) do name = start_agent_on_first_call(cfg) Agent.update(name, fn _old_state -> state end)