Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client for default permission endpoints #146

Open
kushagra189 opened this issue Oct 1, 2022 · 2 comments
Open

Implement client for default permission endpoints #146

kushagra189 opened this issue Oct 1, 2022 · 2 comments
Labels
priority: medium Medium priority type: feature New feature or request type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve
Milestone

Comments

@kushagra189
Copy link
Contributor

Currently, we have kept the default permission endpoints as fixed paths. Instead, we should probably focus on adding a client for the default API, and for that, we know the routes. Users might still be able to reuse that client if they host a /permissions API at the expected base path (if all they are doing is modifying the behavior of the default endpoints). And if they wanna add a completely different API, then they would also need to implement the client along with it.
Hence, we need to implement a client for the default permission endpoints, which then can be used in the controller logic of a FOCA app.

@kushagra189 kushagra189 self-assigned this Oct 1, 2022
@kushagra189 kushagra189 added priority: critical Needs immediate attention type: feature New feature or request type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve labels Oct 1, 2022
@uniqueg
Copy link
Member

uniqueg commented Oct 3, 2022

Just to note that the default client should be passed the base path of course, i.e., everything before /permissions

@uniqueg uniqueg closed this as completed Oct 3, 2022
@uniqueg uniqueg reopened this Oct 3, 2022
@kushagra189
Copy link
Contributor Author

#157

@uniqueg uniqueg added priority: high High priority and removed priority: critical Needs immediate attention labels Dec 2, 2023
@uniqueg uniqueg added priority: medium Medium priority and removed priority: high High priority labels Dec 2, 2023
@uniqueg uniqueg added this to the v1.0.0 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium priority type: feature New feature or request type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve
Projects
Status: Todo access control
Development

No branches or pull requests

2 participants