Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multi file uploads via 'workflow_attachment' in POST request to /runs/ API endpoint #6

Closed
uniqueg opened this issue Aug 20, 2018 · 1 comment
Closed

Handle multi file uploads via 'workflow_attachment' in POST request to /runs/ API endpoint #6

uniqueg opened this issue Aug 20, 2018 · 1 comment
Labels
priority: high High priority type: feature New feature or request type flag: required by specs Compliance with specs requires this change workload: hours Likely takes hours to resolve

Comments

@uniqueg
Copy link
Member

uniqueg commented Aug 20, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
According to the current GA4GH WES specs, workflows and related files can and should be streamed through the POST request to the /runs/ API endpoint. This requires specific handling by the business logic.

Describe the solution you'd like
To be added later.

Describe alternatives you've considered
To be added later.

Additional context
Multi file upload via the multipart/form-data type is not supported by Swagger 2.0. To enable UI support for this feature in connexion (which now supports OpenAPI v3.0, see spec-first/connexion#420), the specs would first need to be migrated to OpenAPI v3.0 (see ga4gh/workflow-execution-service-schemas/issues/43).

Note that support for the workflow_attachment property may be dropped in the future (see ga4gh/workflow-execution-service-schemas/issues/124).
@uniqueg uniqueg mentioned this issue Oct 2, 2018
Closed
@uniqueg uniqueg added this to the Release candidate v1.0.0-rc milestone Oct 9, 2018
@uniqueg uniqueg added bh19 and removed enhancement labels Sep 1, 2019
@uniqueg uniqueg removed this from the Release candidate v1.0.0-rc milestone Sep 1, 2019
@uniqueg uniqueg added on hold and removed bh19 labels Nov 1, 2019
@uniqueg uniqueg added priority: high High priority type flag: required by specs Compliance with specs requires this change type: feature New feature or request workload: hours Likely takes hours to resolve labels Apr 16, 2020
@uniqueg uniqueg mentioned this issue May 8, 2020
Merged
@jvkersch jvkersch mentioned this issue May 10, 2020
Merged
@uniqueg
Copy link
Member Author

uniqueg commented May 13, 2020

Closed by #162

@uniqueg uniqueg closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high High priority type: feature New feature or request type flag: required by specs Compliance with specs requires this change workload: hours Likely takes hours to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uniqueg