-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changes in workflow #25
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pratiksha Sankhe <[email protected]>
Reviewer's Guide by SourceryThis pull request enhances the GitHub Actions workflow for pull request validation by expanding the event types that trigger the workflow and refining the conditions for semantic PR title checks. The changes focus on improving the CI process and updating the pre-commit checks. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psankhe28 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please explain the rationale behind removing the explicit pre-commit installation step? Have you ensured that pre-commit is available in the environment?
- We noticed several unchecked items in the PR checklist, particularly regarding tests and documentation. Could you address these points or explain why they're not applicable to this change?
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/pr_validation.yaml
Outdated
@@ -10,7 +10,7 @@ jobs: | |||
detect-unresolved-conflicts: | |||
name: Detect unresolved merge conflicts | |||
runs-on: ubuntu-latest | |||
needs: semantic-pr | |||
needs: semantic_pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Potential typo in job dependency name
The job dependency has been changed from 'semantic-pr' to 'semantic_pr'. This looks like it might be a typo, as the job is still named 'semantic-pr' later in the file. This could potentially break the workflow execution. Please verify if this change is intentional or if it needs to be corrected to maintain the proper job dependency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 30 30
=========================================
Hits 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pratiksha Sankhe <[email protected]>
Signed-off-by: Pratiksha Sankhe <[email protected]>
Description
Checklist
of this project, including, in particular, with regard to any style guidelines
Conventional Commits specification; in particular, it clearly
indicates that a change is a breaking change
using the PR title as the commit message
changed behavior
or updated existing ones (only for Python, TypeScript, etc.)
(Google-style Python docstrings) for all
packages/modules/functions/classes/methods or updated existing ones
works
Comments
Summary by Sourcery
Enhance the GitHub Actions workflow for pull request validation by expanding the event types that trigger the workflow and refining the conditions for semantic PR title checks.
CI:
Summary by Sourcery
Enhance the GitHub Actions workflow for pull request validation by expanding the event types that trigger the workflow and refining the conditions for semantic PR title checks.
CI: