From 3910b4067aa23082525a4e618e5ae4c7dfd3f903 Mon Sep 17 00:00:00 2001 From: Adam Majer Date: Sat, 11 May 2024 17:25:23 +0200 Subject: [PATCH] benchmark: filter non-present deps from `start-cli-version` PR-URL: https://github.com/nodejs/node/pull/51746 Refs: https://github.com/nodejs/node/pull/51146 Refs: https://github.com/nodejs/node/pull/50684 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung --- benchmark/misc/startup-cli-version.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/benchmark/misc/startup-cli-version.js b/benchmark/misc/startup-cli-version.js index 4dbeb81fc70740..0c8d4848b46cd4 100644 --- a/benchmark/misc/startup-cli-version.js +++ b/benchmark/misc/startup-cli-version.js @@ -9,13 +9,15 @@ const path = require('path'); // tends to be minimal and fewer operations are done to generate // these so that the startup cost is still dominated by a more // indispensible part of the CLI. +// NOTE: not all tools are present in tarball hence need to filter +const availableCli = [ + 'tools/node_modules/eslint/bin/eslint.js', + 'deps/npm/bin/npx-cli.js', + 'deps/npm/bin/npm-cli.js', + 'deps/corepack/dist/corepack.js', +].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli))); const bench = common.createBenchmark(main, { - cli: [ - 'tools/node_modules/eslint/bin/eslint.js', - 'deps/npm/bin/npx-cli.js', - 'deps/npm/bin/npm-cli.js', - 'deps/corepack/dist/corepack.js', - ], + cli: availableCli, count: [30], }); @@ -47,10 +49,6 @@ function spawnProcess(cli, bench, state) { function main({ count, cli }) { cli = path.resolve(__dirname, '../../', cli); - if (!existsSync(cli)) { - return; - } - const warmup = 3; const state = { count, finished: -warmup }; spawnProcess(cli, bench, state);