Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignorable Matcher triggers #293

Open
grantlemons opened this issue Nov 28, 2024 · 0 comments
Open

feat: Ignorable Matcher triggers #293

grantlemons opened this issue Nov 28, 2024 · 0 comments
Labels

Comments

@grantlemons
Copy link
Collaborator

Root Cause of: #243, #287

The Matcher (harper-core/src/linting/matcher.rs) linter recommends replacements in very specific cases. Unfortunately it has some problems.
One of these is that the recommendations cannot be ignored without disabling the lint rule entirely.

I think it would be good to create a more granular configuration for Matcher, so users can enable and disable different recommendations as the choose, but the key thing in my eyes is that users should be able to ignore these, as the fact these behave a lot like spelling suggestions leads users to expect them to be able to interact with them as they would a spelling suggestion.

@grantlemons grantlemons changed the title feat: Ignorable Matcher triggers. feat: Ignorable Matcher triggers Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant