Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

EJP XML manifest items to convert: Reviewing editor details #16

Open
2 tasks
Melissa37 opened this issue Nov 2, 2018 · 2 comments
Open
2 tasks

EJP XML manifest items to convert: Reviewing editor details #16

Melissa37 opened this issue Nov 2, 2018 · 2 comments

Comments

@Melissa37
Copy link

Problem / Motivation

WHO: Production/Bot/Production Vendor
WHEN: Between Export from EJP/xPub and delivery to production vendor
WHERE: In eLife bot processes
WHAT: Senior editor details
WHY: Differences between EJP output and final XML (EJP could not match our requirements exactly)

Proposed solution

Output from ejp:
<contrib-group content-type="section"><contrib contrib-type="assoc_ed" id="author-24218"><name><surname>Frank</surname><given-names>Michael j.</given-names></name><role>Reviewing Editor</role><aff><institution>Brown University</institution><country>United States</country></aff></contrib></contrib-group>

Final XML:
<contrib-group content-type="section">
...
<contrib contrib-type="editor" id="author-10"><name><surname>Collings</surname><given-names>Andy</given-names></name><role>Reviewing Editor</role><aff><institution>eLife Sciences</institution><country>United Kingdom</country></aff></contrib></contrib-group>

Differences:
EJP @contrib-type is"assoc_ed"; final XML is "editor"

Clarification needed and assumptions

  • This is repeated in the sub-article decision letter
  • In the kitchen sink the EJP ID is present in the main article xml but not the sub-article. Is this a mistake? And why is the senior editor EJP ID not in the Kitchen sink but this is?

Tasks

  • Could the details required for the decision letter sub-article be taken from this XML? Would need this detail to be stored and then pulled in and matched up with the right paper when the decision letter is processed.
  • Make the changes necessary to deliver to production

Technical notes

@gnott

User interface / Wireframes

NA

@Melissa37 Melissa37 changed the title Reviewing editor details EJP XML manifest items to convert: Reviewing editor details Nov 2, 2018
@gnott
Copy link
Member

gnott commented Nov 6, 2018

I'm seeing in the input XML for what I think is an Insight article has empty tags for the editor records, I assume they can be ignored:

<contrib-group content-type="section">
<contrib contrib-type="assoc_ed" id="author-">
<name>
<surname/>
<given-names/>
</name>
<role>Reviewing Editor</role>
<aff>
<institution/>
<country/>
</aff>
</contrib>
</contrib-group>
<contrib-group content-type="section">
<contrib contrib-type="editor" id="author-">
<name>
<surname/>
<given-names/>
</name>
<role>Senior Editor</role>
<aff>
<institution/>
<country/>
</aff>
</contrib>
</contrib-group>

@Melissa37
Copy link
Author

Hi @gnott Feature content will have a whole load of their own tickets! For research articles I think this should never be empty and so this is something we'd need validation on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants