Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/credentials #94

Merged
merged 24 commits into from
May 31, 2022
Merged

Feat/credentials #94

merged 24 commits into from
May 31, 2022

Conversation

noandrea
Copy link
Contributor

No description provided.

@noandrea noandrea force-pushed the feat/credentials branch 2 times, most recently from 6d223fe to 0d5507c Compare May 17, 2022 23:32
@noandrea noandrea marked this pull request as ready for review May 22, 2022 09:16
@noandrea noandrea requested a review from a team as a code owner May 22, 2022 09:16
@noandrea noandrea requested review from gsora and PaddyMc May 22, 2022 09:16
@noandrea noandrea added the enhancement New feature or request label May 22, 2022
gsora
gsora reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks for submitting this PR!

x/credential/README.md Outdated Show resolved Hide resolved
x/credential/client/cli/query.go Outdated Show resolved Hide resolved
x/credential/credential.go Show resolved Hide resolved
x/credential/credential.go Show resolved Hide resolved
x/credential/credential.go Outdated Show resolved Hide resolved
x/credential/errors.go Show resolved Hide resolved
x/credential/keeper/credential.go Show resolved Hide resolved
x/credential/keeper/credential.go Show resolved Hide resolved
x/credential/msg_validation.go Show resolved Hide resolved
x/credential/simulation/operations.go Show resolved Hide resolved
PaddyMc
PaddyMc approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, gg!!! 🧙

I think we should merge #113 into this branch then this branch into main ASAP, it's defo in a good enough state to be merged 🎉

@noandrea noandrea mentioned this pull request May 30, 2022
Closed
@noandrea noandrea merged commit e804d35 into main May 31, 2022
@noandrea noandrea deleted the feat/credentials branch May 31, 2022 12:09
@singhhp1069 singhhp1069 mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsora gsora gsora left review comments

@PaddyMc PaddyMc PaddyMc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noandrea @gsora @PaddyMc