Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Portal #71

Open
danirabbit opened this issue May 2, 2023 · 1 comment
Open

Location Portal #71

danirabbit opened this issue May 2, 2023 · 1 comment

Comments

@danirabbit
Copy link
Member

Problem

We're currently using the XDG location portal which uses the request portal but there's quite a bit of room for improvement:

Screenshot from 2023-05-02 10 58 34

  • It uses the action icon find-location instead of the preference icon preferences-system-privacy-location
  • It doesn't use the settings URL scheme for quick access to system settings
  • It doesn't support location accuracy levels, only EXACT or NONE
  • Button labels are too similar and long
  • It's not clear that the reason supplied for app access comes from the app and not from the system

Proposal

Implement our own location portal so that we can improve the design and not regress on functionality from the old location agent

Prior Art (Optional)

screenshot

The only geoclue agent had settings URL, showed location accuracy, etc

@Marukesu
Copy link
Contributor

I think patching the xdg-desktop-portal make more sense than writing an alternative portal frontend to provide the same functionality and then patching the libraries in the os and platform to use our implementation instead of the desktop-agnostic one.

The levels and button labels can be suggested upstream, the icon change and settings uri usage seems elementary-specific, so i believe a patch would be needed for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants