Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut of the module #1

Merged
merged 6 commits into from
Feb 17, 2022
Merged

First cut of the module #1

merged 6 commits into from
Feb 17, 2022

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Feb 16, 2022

Part of the Tchap mainlining.

This module derives an username from an email address in the form "John Doe [Acme]". See the tests and the comments in _map_email_to_displayname for the specifics.

This change copies the behaviour from this bit of synapse-dinsic, and copies the two companion functions that can be found here.

CI is expected to fail due to matrix-org/synapse#12009 not having merged yet, but I've ran the tests and linters locally and it's all green.

@babolivier babolivier added the Z-Time-Tracked Element employees should track their time spent on this issue/PR. label Feb 16, 2022
@babolivier babolivier requested a review from a team February 16, 2022 17:36
Copy link

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it pretty much copies some code fine. 👍

tchap_username_email/__init__.py Outdated Show resolved Hide resolved
@babolivier babolivier merged commit 0bdc933 into main Feb 17, 2022
@babolivier babolivier deleted the babolivier/init branch February 17, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Time-Tracked Element employees should track their time spent on this issue/PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants