Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable authenticated media by default #17889

Merged
merged 12 commits into from
Nov 20, 2024
Merged

Enable authenticated media by default #17889

merged 12 commits into from
Nov 20, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Oct 30, 2024 •
edited
Loading

Feel free to delay landing this PR as the team sees fit.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@turt2live turt2live requested a review from a team as a code owner October 30, 2024 16:53
@github-actions github-actions bot deployed to PR Documentation Preview October 30, 2024 16:54 Active
@github-actions github-actions bot deployed to PR Documentation Preview October 30, 2024 16:57 Active
@github-actions github-actions bot deployed to PR Documentation Preview October 30, 2024 16:59 Active
@github-actions github-actions bot deployed to PR Documentation Preview October 30, 2024 17:01 Active
@Cynn1989 Cynn1989 mentioned this pull request Oct 31, 2024
Closed
@reivilibre
Copy link
Contributor

when we land this, would be good to update the doc to say which version the default changed in

@github-actions github-actions bot deployed to PR Documentation Preview November 7, 2024 16:58 Active
anoadragon453
anoadragon453 reviewed Nov 18, 2024
View reviewed changes
changelog.d/17889.feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should shout about this change in the relevant release version's upgrade notes.

@github-actions github-actions bot deployed to PR Documentation Preview November 18, 2024 16:20 Active
@reivilibre reivilibre self-assigned this Nov 18, 2024
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 18, 2024
@reivilibre
TestAsyncUpload: download with authentication
47ae5c5 
This fixes support with homeservers that enforce authenticated media,
such as Synapse in element-hq/synapse#17889
@reivilibre reivilibre mentioned this pull request Nov 18, 2024
Merged
1 task
@github-actions github-actions bot deployed to PR Documentation Preview November 18, 2024 17:53 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 19, 2024 10:17 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 19, 2024
@reivilibre
Skip TestContent on Synapse
ad2e34c 
This will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@reivilibre reivilibre mentioned this pull request Nov 19, 2024
Merged
1 task
@github-actions github-actions bot deployed to PR Documentation Preview November 19, 2024 10:38 Active
@github-actions github-actions bot deployed to PR Documentation Preview November 19, 2024 11:13 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 19, 2024
@reivilibre
Skip TestContent on Synapse
272068b 
This will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@github-actions github-actions bot deployed to PR Documentation Preview November 19, 2024 15:49 Active
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 20, 2024
@reivilibre
TestAsyncUpload: download with authentication (#746)
fde26d9 
This fixes support with homeservers that enforce authenticated media,
such as Synapse in element-hq/synapse#17889
reivilibre added a commit to matrix-org/complement that referenced this pull request Nov 20, 2024
@reivilibre
Skip tests requiring unauthenticated media on Synapse (#747)
9e9f6d3 
These will be expected to fail when Synapse enforces
authenticated media by default in
element-hq/synapse#17889
@reivilibre reivilibre merged commit d0a474d into develop Nov 20, 2024
41 checks passed
@reivilibre reivilibre deleted the travis/auth-always-on branch November 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 left review comments

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@reivilibre reivilibre

Labels
X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turt2live @reivilibre @anoadragon453 @erikjohnston