Add a wrapper to convert file streams to multipart #17327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we need to wrap the responders rather than changing them
| self.producer = producer | ||
| self.streaming = streaming | ||
|
|
||
| self.wrapped_consumer.registerProducer(self, streaming) |
There was a problem hiding this comment.
Suggested change
| self.wrapped_consumer.registerProducer(self, streaming) | |
| self.wrapped_consumer.registerProducer(self, True) |
Would be good to know why you changed it to this. My understanding is that MultipartFileConsumer operates as a IPushProducer irrespective of what producer is, and so we should we always set the streaming flag in registerProducer.
There was a problem hiding this comment.
So this was a change that I made after I ran an integration test and found that the file streaming response was hanging indefinitely causing the original request to time out - changing it to this worked and so I didn't think much about it, but it sounds like maybe I need to investigate further...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on https://github.com/element-hq/synapse/compare/erikj/fixup_multipart
#17172 changed the storage provider fetch API, which caused breakage in 3rd party storage providers.
This PR fixes that by removing the change to the api, and adding a multipart file consumer which consumes a file stream and converts it to mulipart before streaming that out to the requester.