Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict MSC4108 content-type to text/plain #17122

Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Apr 25, 2024

For attention of @anoadragon453 to land in #17056

@hughns hughns requested a review from a team as a code owner April 25, 2024 11:06
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, including make_request alternations. Thanks!

None,
));
}

Ok(content_type.into())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know the content type will always by text/plain, we can probably simplify the code in this function and Session a bit.

Happy to have that be done in a follow-up PR though.

@anoadragon453 anoadragon453 merged commit 86c7797 into element-hq:quenting/msc4108 Apr 25, 2024
38 checks passed
@hughns hughns deleted the hughns/msc4108-content-type branch April 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants