Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more correct changelog entries for refactoring Generator usage #17890

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Oct 31, 2024

Use more correct changelog entries for refactoring Generator usage

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@@ -1 +0,0 @@
Avoid lost data on some database query retries.
Copy link
Contributor Author

@MadLittleMods MadLittleMods Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all of these because the PR's for these don't actually help with data loss at all.

The PR's simply update a few spots so down the line we can update the type hints to be explicit which will help with us making mistakes in the future.

Context: matrix-org/synapse#15439

To be clear, they didn't fix any bugs or were a problem before. But changing them to be a Sequence will allow us to update the type hint to be Sequence instead of Any

@MadLittleMods MadLittleMods marked this pull request as ready for review October 31, 2024 02:39
@MadLittleMods MadLittleMods requested a review from a team as a code owner October 31, 2024 02:39
@@ -0,0 +1 @@
Refactor database calls to remove `Generator` usage.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devonh (maintainer ping) We should merge this one before a release tomorrow so we don't have to deal with weird changelog conflicts.

@devonh devonh merged commit eac170b into develop Nov 5, 2024
31 checks passed
@devonh devonh deleted the madlittlemods/update-generator-refactor-changelogs branch November 5, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants