Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script to check GH token #17803

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

erikjohnston
Copy link
Member

The current logic didn't work.

Looks like I didn't properly test it when we added the logic in #17562

@erikjohnston erikjohnston marked this pull request as ready for review October 8, 2024 14:45
@erikjohnston erikjohnston requested a review from a team as a code owner October 8, 2024 14:45
scripts-dev/release.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew Morgan <[email protected]>
@erikjohnston erikjohnston enabled auto-merge (squash) October 10, 2024 08:49
@erikjohnston erikjohnston merged commit f6a3e5e into develop Oct 10, 2024
31 checks passed
@erikjohnston erikjohnston deleted the erikj/release_gh_token_check branch October 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants