Millions of /query/profile requests

[matrixbot]

This issue has been migrated from #12921.

---

Over the last hour (in which I did rejoin #element:matrix.org, but still), matrix.org has sent my server 1892 GET /_matrix/federation/v1/query/profile?user_id=%40richvdh%3Asw1v.org requests.

They aren't an inherent problem, since they can be served pretty quickly, but this still smacks of huge inefficiency somewhere.

[S7evinK]

As @richvdh mentioned here, this is due to Synapse requesting displayname and avatar_url in separate requests:

synapse/synapse/rest/client/profile.py

Lines 204 to 205 in 0621e8e

	displayname = await self.profile_handler.get_displayname(user)
	avatar_url = await self.profile_handler.get_avatar_url(user)