Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library is making assumptions about the source file format. #4

Closed
pixlwave opened this issue Aug 22, 2022 · 2 comments · Fixed by #5
Closed

The library is making assumptions about the source file format. #4

pixlwave opened this issue Aug 22, 2022 · 2 comments · Fixed by #5

Comments

@pixlwave
Copy link
Member

pixlwave commented Aug 22, 2022

Describe the bug
As described in element-hq/element-ios#6603, OGGConverter and OGGDecoder make assumptions about the format of the file, in particular that the file is mono. This can result in incorrect decoding and playback when a user tries to play an opus file that wasn't sent using the voice message functionality.

To Reproduce
See the issue in Element iOS

Expected behavior
The library should determine the format of the audio decode from the file rather than having this hard-coded.

Smartphone (please complete the following information):
iPhone 12 on iOS 15.6.1 running Element 1.8.27

@pixlwave
Copy link
Member Author

Also potentially related is element-hq/element-ios#6584 but still waiting on more info for that one.

@pixlwave
Copy link
Member Author

Update on element-hq/element-ios#6584, its crashing when creating the decoder which is returning a nil value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant