Attach Screenshot in Bug Report Screen

[Velin92]

Added an Attach Screenshot button that will add a screenshot to the bug report:

RPReplay_Final1676470242.MP4

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️	Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against 01eaa40

[codecov]

Codecov Report

Base: 48.60% // Head: 48.16% // Decreases project coverage by -0.45% ⚠️

Coverage data is based on head (e569a13) compared to base (872c911).
Patch coverage: 2.04% of modified lines in pull request are covered.

❗ Current head e569a13 differs from pull request most recent head 01eaa40. Consider uploading reports for the commit 01eaa40 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #578      +/-   ##
===========================================
- Coverage    48.60%   48.16%   -0.45%     
===========================================
  Files          262      263       +1     
  Lines        15067    15110      +43     
  Branches      9966     9982      +16     
===========================================
- Hits          7324     7278      -46     
- Misses        7464     7554      +90     
+ Partials       279      278       -1     

Flag	Coverage Δ
unittests	20.93% <2.04%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mentX/Sources/Other/AccessibilityIdentifiers.swift	0.00% <ø> (ø)
...urces/Other/SwiftUI/Views/SettingsDefaultRow.swift	66.66% <0.00%> (-29.34%)	⬇️
...es/Other/SwiftUI/Views/SettingsRowLabelStyle.swift	0.00% <0.00%> (ø)
...urces/Screens/BugReport/BugReportCoordinator.swift	27.08% <0.00%> (ø)
...urces/Screens/BugReport/View/BugReportScreen.swift	51.97% <0.00%> (-25.81%)	⬇️
...s/Screens/RoomDetails/View/RoomDetailsScreen.swift	70.00% <0.00%> (-10.37%)	⬇️
...Sources/Screens/Settings/View/SettingsScreen.swift	61.36% <ø> (ø)
.../Sources/Services/BugReport/BugReportService.swift	70.93% <0.00%> (ø)
...Sources/Screens/BugReport/BugReportViewModel.swift	36.95% <20.00%> (-3.59%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pixlwave]

Looks good to me. One small comment from the screen recording, could the progress bar say "Sending" instead of loading?

Also should probably ask for a design review on this :)

[stefanceriu]

lgtm too 👍

[amshakal]

Hey!! Thanks for working on this. I have a few suggestions/tweaks:

1. Is it possible be reduce the size of the text box so that the info/buttons below it are more visible?
2. Can we add the 'attach screenshot' button above 'send logs'? It fit's better with the overall heiarchy of this screen.
3. Can we add an icon to the left of attach screenshot to make it super obvious what the user is supposed to do here, it also matches with the treatment we are giving buttons within settings.

Screenshot for ref:

Figma file for ref:
https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X-(new)?node-id=123%3A21855&t=cBA1DmfD4awGuMCW-1

[Velin92]

Hey!! Thanks for working on this. I have a few suggestions/tweaks:

1. Is it possible be reduce the size of the text box so that the info/buttons below it are more visible?
2. Can we add the 'attach screenshot' button above 'send logs'? It fit's better with the overall heiarchy of this screen.
3. Can we add an icon to the left of attach screenshot to make it super obvious what the user is supposed to do here, it also matches with the treatment we are giving buttons within settings.

Screenshot for ref:

Figma file for ref: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X-(new)?node-id=123%3A21855&t=cBA1DmfD4awGuMCW-1

Updated the screen recording in the PR description to show the requested changes.

[pixlwave]

Changes look good to me. There's a couple more places where we could use the label style: RoomDetailsScreen in the aboutSection and the securitySection.

[amshakal]

💯

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication