Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the public search feature flag in the developer settings and disable it by default. #3528

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 18, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner November 18, 2024 13:18
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 18, 2024 13:18
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e7ffc00

Copy link

sonarcloud bot commented Nov 18, 2024

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (bef1eda) to head (e7ffc00).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3528      +/-   ##
===========================================
- Coverage    78.72%   78.70%   -0.03%     
===========================================
  Files          752      752              
  Lines        62871    62936      +65     
===========================================
+ Hits         49498    49536      +38     
- Misses       13373    13400      +27     
Flag Coverage Δ
unittests 69.63% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 6b6420a into develop Nov 18, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/publicSearchFF branch November 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants