Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share extension app group so it works for nightlies too #3520

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner November 15, 2024 12:43
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team November 15, 2024 12:43
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

github-actions bot commented Nov 15, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against b2e73bf

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhhhh, nice find 👍

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 15, 2024
@stefanceriu stefanceriu merged commit 4ea276d into develop Nov 15, 2024
8 of 9 checks passed
@stefanceriu stefanceriu deleted the stefan/shareExtensionFix branch November 15, 2024 12:59
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (7e192b7) to head (b2e73bf).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3520      +/-   ##
===========================================
+ Coverage    78.54%   78.57%   +0.02%     
===========================================
  Files          751      752       +1     
  Lines        62725    62846     +121     
===========================================
+ Hits         49270    49380     +110     
- Misses       13455    13466      +11     
Flag Coverage Δ
unittests 69.50% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants