-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the RustSDK to v1.0.67 #3512
Conversation
Generated by 🚫 Danger Swift against b18d66f |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3512 +/- ##
===========================================
- Coverage 78.45% 78.43% -0.02%
===========================================
Files 751 752 +1
Lines 62584 62735 +151
===========================================
+ Hits 49099 49205 +106
- Misses 13485 13530 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun update 🫠
hasher.combine(timelineID) | ||
} | ||
|
||
static var randomSendHandle: SendHandleProxy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I think I prefer call these mock
so it is super clear what it is.
static var randomSendHandle: SendHandleProxy { | |
static var mock: SendHandleProxy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, totally missed these when adopting captions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be committed.
case sdkError(Swift.Error) | ||
} | ||
|
||
let timelineID: TimelineItemIdentifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency I think we should call this itemID
tbf.
Quality Gate passedIssues Measures |
No description provided.