-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline Reactions: Emoji picker #350
Conversation
Generated by 🚫 Danger Swift against 4d4a6e6 |
Codecov ReportBase: 33.58% // Head: 32.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #350 +/- ##
===========================================
- Coverage 33.58% 32.48% -1.11%
===========================================
Files 233 245 +12
Lines 15429 16252 +823
Branches 9362 10032 +670
===========================================
+ Hits 5182 5279 +97
- Misses 10093 10810 +717
- Partials 154 163 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hey @stefanceriu, as there is no UI and backend support to finish this ticket I am not sure if it should be merged. Because we still don't know how the reactions menu will be presented as we agreed I am displaying a simple view and by selecting it, emoji sheet is presented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some comments inline 👍
ElementX/Sources/Screens/RoomScreen/View/Supplementary/TimelineItemEmojiReactionsMenuView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EmojiPickerScreen/View/EmojiPickerScreenScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EmojiPickerScreen/View/EmojiPickerScreenScreen.swift
Outdated
Show resolved
Hide resolved
@stefanceriu thank you for your comments! 👍 I fixed them, please let me know if there is something else |
# Conflicts: # ElementX.xcodeproj/project.pbxproj # ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift # ElementX/Sources/Screens/RoomScreen/View/TimelineItemList.swift
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Implementation of the emoji picker sheet (as part of #111). There is no UI and backend support for this yet. Updated to the latest emoji JSON.