Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Reactions: Emoji picker #350

Merged
merged 21 commits into from
Dec 6, 2022
Merged

Conversation

paleksandrs
Copy link
Contributor

Implementation of the emoji picker sheet (as part of #111). There is no UI and backend support for this yet. Updated to the latest emoji JSON.

Simulator Screen Recording - iPhone 14 Pro - 2022-12-05 at 10 29 15

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against 4d4a6e6

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 33.58% // Head: 32.48% // Decreases project coverage by -1.10% ⚠️

Coverage data is based on head (22eae27) compared to base (dcedb3f).
Patch coverage: 28.18% of modified lines in pull request are covered.

❗ Current head 22eae27 differs from pull request most recent head 4d4a6e6. Consider uploading reports for the commit 4d4a6e6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
- Coverage    33.58%   32.48%   -1.11%     
===========================================
  Files          233      245      +12     
  Lines        15429    16252     +823     
  Branches      9362    10032     +670     
===========================================
+ Hits          5182     5279      +97     
- Misses       10093    10810     +717     
- Partials       154      163       +9     
Flag Coverage Δ
unittests 13.95% <25.37%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Generated/Strings.swift 3.26% <0.00%> (-0.13%) ⬇️
...ojiPickerScreen/EmojiPickerScreenCoordinator.swift 0.00% <0.00%> (ø)
...ns/EmojiPickerScreen/EmojiPickerScreenModels.swift 0.00% <0.00%> (ø)
...EmojiPickerScreen/EmojiPickerScreenViewModel.swift 0.00% <0.00%> (ø)
...EmojiPickerScreen/View/EmojiPickerHeaderView.swift 0.00% <0.00%> (ø)
...ens/EmojiPickerScreen/View/EmojiPickerScreen.swift 0.00% <0.00%> (ø)
...PickerScreen/View/EmojiPickerSearchFieldView.swift 0.00% <0.00%> (ø)
.../Supplementary/TimelineItemReactionsMenuView.swift 0.00% <0.00%> (ø)
...es/Screens/RoomScreen/View/TimelineTableView.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Media/MediaSourceProxy.swift 0.00% <ø> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paleksandrs
Copy link
Contributor Author

Hey @stefanceriu, as there is no UI and backend support to finish this ticket I am not sure if it should be merged. Because we still don't know how the reactions menu will be presented as we agreed I am displaying a simple view and by selecting it, emoji sheet is presented.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some comments inline 👍

@paleksandrs
Copy link
Contributor Author

@stefanceriu thank you for your comments! 👍 I fixed them, please let me know if there is something else

# Conflicts:
#	ElementX.xcodeproj/project.pbxproj
#	ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift
#	ElementX/Sources/Screens/RoomScreen/View/TimelineItemList.swift
@paleksandrs paleksandrs marked this pull request as ready for review December 6, 2022 13:14
@paleksandrs paleksandrs enabled auto-merge (squash) December 6, 2022 13:49
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paleksandrs paleksandrs merged commit 7f91852 into develop Dec 6, 2022
@paleksandrs paleksandrs deleted the aleksandrs/111_emoji_picker branch December 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants