Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start syncing when receiving a background VoIP call for the cases in which the app was suspended but not terminated #3491

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

…which the app was suspended but not terminated.
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Nov 6, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner November 6, 2024 18:09
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 6, 2024 18:09
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🤞🤞

Copy link

github-actions bot commented Nov 6, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 9a44b5e

@stefanceriu stefanceriu merged commit 4ac527a into develop Nov 6, 2024
8 checks passed
@stefanceriu stefanceriu deleted the stefan/callKitSync branch November 6, 2024 18:11
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (171fc2c) to head (9a44b5e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3491      +/-   ##
===========================================
- Coverage    77.66%   77.61%   -0.05%     
===========================================
  Files          745      745              
  Lines        61668    61672       +4     
===========================================
- Hits         47894    47868      -26     
- Misses       13774    13804      +30     
Flag Coverage Δ
unittests 69.28% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants