Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of the frequently used emojis when showing them in the full reaction picker #3455

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Oct 26, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 26, 2024 15:24
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against ad5b22e

Copy link

sonarcloud bot commented Oct 26, 2024

Copy link

codecov bot commented Oct 26, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
849 4 845 0
View the top 3 failed tests by shortest run time
PreviewTests test_roomDirectorySearchScreen()
Stack Traces | 2.26s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomDirectorySearchScreen-iPhone-16-pseudo.1.png"
@+
"file:.../tmp/PreviewTests/test_roomDirectorySearchScreen-iPhone-16-pseudo.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9977398 is less than required 1.0
The lowest perceptual color precision 0.70734376 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_secureBackupRecoveryKeyScreen()
Stack Traces | 2.6s run time
failed - Snapshot "Not set up" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"
@+
"file:.../tmp/PreviewTests/test_secureBackupRecoveryKeyScreen-iPhone-16-en-GB.Not-set-up.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9957123 is less than required 1.0
The lowest perceptual color precision 0.70734376 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_createRoom()
Stack Traces | 4.46s run time
failed - Snapshot "Create Room" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"
@+
"file:.../tmp/PreviewTests/test_createRoom-iPhone-16-en-GB.Create-Room.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.957489 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@stefanceriu stefanceriu merged commit b514d54 into develop Oct 27, 2024
8 of 9 checks passed
@stefanceriu stefanceriu deleted the stefan/frequentEmojiOrderFix branch October 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants