Fix a bug where uploaded images could have the wrong aspect ratio in the timeline. #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against d1ebd0a |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3435 +/- ##
===========================================
- Coverage 77.78% 77.74% -0.04%
===========================================
Files 738 738
Lines 60626 60677 +51
===========================================
+ Hits 47157 47175 +18
- Misses 13469 13502 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/thumbnail-orientation
branch
from
f66ade1
to
d1ebd0a
Compare
|
Velin92
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the refactor in #3412 I made the image size calculations always come from the CGImageSource. This introduced a bug where if we hadn't just scaled the image the orientation wasn't taken into account.
This PR fixes that and adds a test too.