Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the project to use Xcode 16. #3303

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Update the project to use Xcode 16. #3303

merged 8 commits into from
Sep 23, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 18, 2024

Update the project to use Xcode 16 and the iOS 18 simulator.

  • Fastlane uses Xcode 16
  • Unit Tests
    • Pass locally
    • Pass on CI
  • Preview Tests
    • Pass locally
    • Pass on CI
  • UI Tests
    • Pass locally
    • Pass on CI (we're going to prioritise building with Xcode 16 over these as we need it to fix a bug with interactive dismissal of media).
  • Integration Tests
    • Pass locally
    • Pass on CI
  • Xcode Cloud uses Xcode 16

Bugs

@pixlwave pixlwave requested a review from a team as a code owner September 18, 2024 15:18
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 18, 2024 15:18
@pixlwave pixlwave marked this pull request as draft September 18, 2024 15:18
@pixlwave pixlwave removed the request for review from stefanceriu September 18, 2024 15:18
Copy link

github-actions bot commented Sep 18, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9f90298

Copy link

codecov bot commented Sep 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
824 1 823 0
View the top 1 failed tests by shortest run time
UserSessionFlowCoordinatorTests testReplaceDetailsWithTimeline()
Stack Traces | 3.73s run time
XCTAssertTrue failed (.../UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:165)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Sep 19, 2024
@pixlwave pixlwave force-pushed the doug/xcode-16 branch 3 times, most recently from 7c35d50 to 7a1d406 Compare September 23, 2024 11:19
@pixlwave pixlwave marked this pull request as ready for review September 23, 2024 11:19
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Sep 23, 2024

@pixlwave pixlwave enabled auto-merge (rebase) September 23, 2024 14:42
@pixlwave pixlwave merged commit 4996137 into develop Sep 23, 2024
6 of 7 checks passed
@pixlwave pixlwave deleted the doug/xcode-16 branch September 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants