Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force frame sizes for timeline items that are missing sizing info #3259

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Force frame sizes for timeline items that are missing sizing info #3259

merged 2 commits into from
Sep 11, 2024

Conversation

stefanceriu
Copy link
Member

Screenshot 2024-09-11 at 10 57 56

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 11, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 11, 2024 07:58
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 11, 2024 07:58
pixlwave
pixlwave approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small thought about the naming.

ElementX/Sources/Other/SwiftUI/Layout/TimelineMediaFrame.swift Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 927a43e

pixlwave
pixlwave approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 😁

@stefanceriu stefanceriu merged commit 84a3ffc into develop Sep 11, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the stefan/3173 branch September 11, 2024 12:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-bugfix for bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave