Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redacted messages to be viewed and unpinned #3251

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 10, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner September 10, 2024 12:19
@Velin92 Velin92 requested review from stefanceriu and removed request for a team September 10, 2024 12:19
Copy link

github-actions bot commented Sep 10, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3194c0a

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (5394523) to head (3194c0a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...imeline/View/ItemMenu/TimelineItemMenuAction.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3251   +/-   ##
========================================
  Coverage    71.05%   71.05%           
========================================
  Files          734      734           
  Lines        65131    65131           
========================================
  Hits         46279    46279           
  Misses       18852    18852           
Flag Coverage Δ
unittests 68.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 enabled auto-merge (squash) September 10, 2024 13:25
@Velin92 Velin92 merged commit 4ec6098 into develop Sep 10, 2024
5 checks passed
@Velin92 Velin92 deleted the mauromito/redacted_messages_can_be_unpinned branch September 10, 2024 13:25
Copy link

sonarcloud bot commented Sep 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants