Pin Tweaks

ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift

@@ -63,10 +63,13 @@ struct PinnedItemsBannerView: View {
 
     private var content: some View {
         VStack(alignment: .leading, spacing: 0) {
-            Text(state.bannerIndicatorDescription)
-                .font(.compound.bodySM)
-                .foregroundColor(.compound.textActionAccent)
-                .lineLimit(1)
+            // Only the display the indicator description for more than 1 pinned item
+            if state.count > 1 {
+                Text(state.bannerIndicatorDescription)
+                    .font(.compound.bodySM)
+                    .foregroundColor(.compound.textActionAccent)
+                    .lineLimit(1)
+            }
             Text(state.displayedMessage)
                 .font(.compound.bodyMD)
                 .foregroundColor(.compound.textPrimary)

ElementX/Sources/Screens/Timeline/TimelineTableViewController.swift

@@ -308,8 +308,12 @@ class TimelineTableViewController: UIViewController {
         guard let dataSource else { return }
 
         var snapshot = NSDiffableDataSourceSnapshot<TimelineSection, String>()
-        snapshot.appendSections([.typingIndicator])
-        snapshot.appendItems([TimelineTypingIndicatorCell.reuseIdentifier])
+
+        // We don't want to display the typing notification in this timeline
+        if !coordinator.context.viewState.isPinnedEventsTimeline {
+            snapshot.appendSections([.typingIndicator])
+            snapshot.appendItems([TimelineTypingIndicatorCell.reuseIdentifier])
+        }
         snapshot.appendSections([.main])
         snapshot.appendItems(timelineItemsIDs)
 

ElementX/Sources/Screens/Timeline/View/ItemMenu/TimelineItemMenuAction.swift

@@ -100,7 +100,7 @@ enum TimelineItemMenuAction: Identifiable, Hashable {
 
     var canAppearInPinnedEventsTimeline: Bool {
         switch self {
-        case .viewInRoomTimeline, .pin, .unpin, .forward, .redact:
+        case .viewInRoomTimeline, .pin, .unpin, .forward:
             return true
         default:
             return false

ElementX/Sources/Screens/Timeline/View/ItemMenu/TimelineItemMenuActionProvider.swift

@@ -58,14 +58,14 @@ struct TimelineItemMenuActionProvider {
         if item.isForwardable {
             actions.append(.forward(itemID: item.id))
         }
-
-        if canCurrentUserPin, let eventID = item.id.eventID {
-            actions.append(pinnedEventIDs.contains(eventID) ? .unpin : .pin)
-        }
 
         if item.isEditable {
             actions.append(.edit)
         }
+
+        if canCurrentUserPin, let eventID = item.id.eventID {
+            actions.append(pinnedEventIDs.contains(eventID) ? .unpin : .pin)
+        }
 
         if item.isCopyable {
             actions.append(.copy)

ElementX/Sources/Screens/Timeline/View/Style/TimelineItemBubbledStylerView.swift

@@ -102,7 +102,9 @@ struct TimelineItemBubbledStylerView<Content: View>: View {
                     context.send(viewAction: .displayTimelineItemMenu(itemID: timelineItem.id))
                 }
 
-            if !timelineItem.properties.reactions.isEmpty {
+            // Do not display reactions in the pinned events timeline
+            if !context.viewState.isPinnedEventsTimeline,
+               !timelineItem.properties.reactions.isEmpty {
                 TimelineReactionsView(context: context,
                                       itemID: timelineItem.id,
                                       reactions: timelineItem.properties.reactions,