Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite how out of band verification changes are handled within the onboarding flows #3234

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 5, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 5, 2024 14:26
@stefanceriu stefanceriu enabled auto-merge (rebase) September 5, 2024 14:26
Copy link

github-actions bot commented Sep 5, 2024

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against 329f132

Copy link

sonarcloud bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.50%. Comparing base (dc85cb1) to head (329f132).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3234      +/-   ##
===========================================
- Coverage    45.51%   45.50%   -0.01%     
===========================================
  Files          723      723              
  Lines        53927    53958      +31     
===========================================
+ Hits         24543    24554      +11     
- Misses       29384    29404      +20     
Flag Coverage Δ
unittests 35.56% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 2da4059 into develop Sep 6, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/3231 branch September 6, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant