-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new RoomProxyType
and treat rooms differently based on their membership state
#3187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice tidy-up, this is much safer 👏👏👏
Did it need any Rust changes in the end?
3b85234
to
9c878a8
Compare
Generated by 🚫 Danger Swift against a11b549 |
9c878a8
to
35ebe6c
Compare
…eir membership state
35ebe6c
to
a11b549
Compare
Quality Gate failedFailed conditions |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3187 +/- ##
===========================================
- Coverage 77.90% 77.66% -0.25%
===========================================
Files 717 718 +1
Lines 56527 56617 +90
===========================================
- Hits 44039 43970 -69
- Misses 12488 12647 +159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.