-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room List Filters implementation #2423
Conversation
- more readable filtering API - wrote some docs on its usage
30bb998
to
ee5aa0c
Compare
Generated by 🚫 Danger Swift against 4462c64 |
ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift
Show resolved
Hide resolved
A notification or a mention will always increase the number of unread messages, see this test. Right now, the |
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking awesome, nicely done! 👏
Left a bunch of comments but most of them are about naming and moving things around.
ElementX/Sources/Screens/GlobalSearchScreen/GlobalSearchScreenViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/GlobalSearchScreen/GlobalSearchScreenViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProviderProtocol.swift
Show resolved
Hide resolved
We want the unreads filter to essentially be displayed only when there is a green badge. So the filtering must comply with the push rules of the room. |
…m/vector-im/element-x-ios into mauroromito/filter_implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 it!
Quality Gate passedIssues Measures |
A new SDK version is required for this to be merged (PR)
NOTE: in the video unreads work only for unread message not for unread notifications only yet, this is because we are missing the last bit of the implementation in the SDK
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-05.at.18.20.38.mp4