Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room List Filters implementation #2423

Merged
merged 17 commits into from
Feb 8, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 6, 2024

A new SDK version is required for this to be merged (PR)

NOTE: in the video unreads work only for unread message not for unread notifications only yet, this is because we are missing the last bit of the implementation in the SDK

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-05.at.18.20.38.mp4

@Velin92 Velin92 changed the title WIP RoomList Filter implementation WIP Room List Filters implementation Feb 6, 2024
@Velin92 Velin92 force-pushed the mauroromito/filter_implementation branch from 30bb998 to ee5aa0c Compare February 6, 2024 15:20
Copy link

github-actions bot commented Feb 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4462c64

@Velin92 Velin92 marked this pull request as ready for review February 6, 2024 16:05
@Velin92 Velin92 requested a review from a team as a code owner February 6, 2024 16:05
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 6, 2024 16:05
@Velin92 Velin92 changed the title WIP Room List Filters implementation Room List Filters implementation Feb 6, 2024
@Hywan
Copy link
Member

Hywan commented Feb 7, 2024

NOTE: in the video unreads work only for unread message not for unread notifications only yet, this is because we are missing the last bit of the implementation in the SDK

A notification or a mention will always increase the number of unread messages, see this test.

Right now, the unread filter checks for num_unread, which looks correct. Do you expect another behaviour?

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking awesome, nicely done! 👏
Left a bunch of comments but most of them are about naming and moving things around.

@Velin92
Copy link
Member Author

Velin92 commented Feb 7, 2024

NOTE: in the video unreads work only for unread message not for unread notifications only yet, this is because we are missing the last bit of the implementation in the SDK

A notification or a mention will always increase the number of unread messages, see this test.

Right now, the unread filter checks for num_unread, which looks correct. Do you expect another behaviour?

We want the unreads filter to essentially be displayed only when there is a green badge. So the filtering must comply with the push rules of the room.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it!

# Conflicts:
#	ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift
@Velin92 Velin92 enabled auto-merge (squash) February 8, 2024 15:15
@Velin92 Velin92 disabled auto-merge February 8, 2024 15:50
@Velin92 Velin92 merged commit 224e4e4 into develop Feb 8, 2024
3 checks passed
@Velin92 Velin92 deleted the mauroromito/filter_implementation branch February 8, 2024 15:50
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants