Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles often don’t load in timeline. #3110

Closed
ara4n opened this issue Aug 1, 2024 · 3 comments
Closed

Profiles often don’t load in timeline. #3110

ara4n opened this issue Aug 1, 2024 · 3 comments
Assignees
@stefanceriu
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Aug 1, 2024

Steps to reproduce

  1. open a room for the first time in a session
  2. about 30% of the time, no profiles load - just raw mxids:

IMG_7912

  1. go back to roomlist and reenter room
  2. profiles now appear

Outcome

What did you expect?

reliable profiles everywhere

What happened instead?

racey flakiness

Your phone model

No response

Operating system version

No response

Application version

667

Homeserver

No response

Will you send logs?

No
@ara4n
Copy link
Member Author

ara4n commented Aug 2, 2024

(this is with SSS)

@manuroe manuroe added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 2, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 2, 2024

...although i think it was also happening pre-SSS

@manuroe manuroe removed the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 5, 2024
@stefanceriu stefanceriu self-assigned this Aug 5, 2024
@pixlwave pixlwave added T-Defect A-Timeline X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Aug 5, 2024
@stefanceriu
Copy link
Member

This indeed has nothing to do with SSS. I can easily reproduce it by dropping the connection after loading timeline items/backpaginating.

It does also fix itself when the timeline item in question re-appears on screen.

Both of these are expected per https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift#L400 and https://github.com/element-hq/element-x-ios/blob/develop/ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift#L143

What would the new desired behavior be, should I additionally re-fetch all of them when the network conditions change?

@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 12, 2024
@stefanceriu stefanceriu mentioned this issue Aug 14, 2024
Closed
stefanceriu added a commit that referenced this issue Aug 29, 2024
@stefanceriu
Fixes #3110 - Manually populate profiles when displaying the timeline.
6039a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically try reloading failed images on network changes element-hq/element-x-ios
5 participants
@stefanceriu @ara4n @pixlwave @manuroe @Velin92