-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific UX for Expected UTDs due to membership #2740
Conversation
Generated by 🚫 Danger Swift against a6b2ae8 |
b9649b4
to
c45e8f6
Compare
c45e8f6
to
acaa054
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2740 +/- ##
===========================================
- Coverage 74.69% 74.61% -0.08%
===========================================
Files 581 581
Lines 40720 40766 +46
===========================================
+ Hits 30415 30417 +2
- Misses 10305 10349 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks 👍
Fixes https://github.com/element-hq/crypto-internal/issues/219
Fixes https://github.com/element-hq/crypto-internal/issues/221
Draft as based on this rust-sdk PR matrix-org/matrix-rust-sdk#3337
UTD of room with shared history will be presented as:
And the error will be reported to posthog with a newly created code from matrix-analytics-event 0.20
Includes a new string created in localazy.
Pull Request Checklist
UI changes have been tested with: