Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific UX for Expected UTDs due to membership #2740

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Apr 24, 2024

Fixes https://github.com/element-hq/crypto-internal/issues/219
Fixes https://github.com/element-hq/crypto-internal/issues/221

Draft as based on this rust-sdk PR matrix-org/matrix-rust-sdk#3337

UTD of room with shared history will be presented as:
image

And the error will be reported to posthog with a newly created code from matrix-analytics-event 0.20

Includes a new string created in localazy.

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

Copy link

github-actions bot commented Apr 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a6b2ae8

@pixlwave pixlwave force-pushed the valere/expected_utd_membership branch from c45e8f6 to acaa054 Compare April 26, 2024 13:07
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 49.09091% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 74.61%. Comparing base (1b8d895) to head (a6b2ae8).

Files Patch % Lines
.../Sources/Services/Analytics/AnalyticsService.swift 0.00% 11 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 9 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 7 Missing ⚠️
...reen/View/Timeline/EncryptedRoomTimelineView.swift 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2740      +/-   ##
===========================================
- Coverage    74.69%   74.61%   -0.08%     
===========================================
  Files          581      581              
  Lines        40720    40766      +46     
===========================================
+ Hits         30415    30417       +2     
- Misses       10305    10349      +44     
Flag Coverage Δ
unittests 62.21% <49.09%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr marked this pull request as ready for review April 26, 2024 14:21
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner April 26, 2024 14:21
@BillCarsonFr BillCarsonFr requested review from Velin92 and removed request for a team April 26, 2024 14:21
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@pixlwave pixlwave merged commit bd9a171 into develop Apr 26, 2024
9 checks passed
@pixlwave pixlwave deleted the valere/expected_utd_membership branch April 26, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants