Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions: Add a warning on servers where MSC 4028 is not supported #2078

Closed
Tracked by #2065
Velin92 opened this issue Nov 13, 2023 · 1 comment · Fixed by #2081
Closed
Tracked by #2065

Mentions: Add a warning on servers where MSC 4028 is not supported #2078

Velin92 opened this issue Nov 13, 2023 · 1 comment · Fixed by #2081
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design

Comments

@Velin92
Copy link
Member

Velin92 commented Nov 13, 2023

We check through the API I exposed matrix-org/matrix-rust-sdk#2840 if the homeserver supports MSC 4028 and if not, an alert saying something like "be aware that your homeserver does not support the Mentions only options for ecrypted rooms which may result in the loss of all pushes if enabled" (final copy TBD) is shown.

This should be shown in Advanced Settings -> Notifications -> Group or Direct, as soon as the view is loaded
This should also be shown in Room Details -> Notifications -> Custom Settings on, but only and only if the room is encrypted otherwise we can avoid that

We still allow the user to do any change, we just inform them that it might affect encrypted rooms.

@Velin92 Velin92 added A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design labels Nov 13, 2023
@Velin92 Velin92 changed the title Mentions: Push notifications display user mentions differently Mentions: Add a warning on servers where MSC 4028 is not supported Nov 13, 2023
@Velin92
Copy link
Member Author

Velin92 commented Nov 13, 2023

Kamino cloned this issue to vector-im/element-x-android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant