Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline - Reactions #111

Closed
stefanceriu opened this issue Jun 29, 2022 · 1 comment
Closed

Timeline - Reactions #111

stefanceriu opened this issue Jun 29, 2022 · 1 comment
Assignees
Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@stefanceriu
Copy link
Member

stefanceriu commented Jun 29, 2022

As an user I would like to react on messages and see reactions from other participants so that I can better follow the conversation

  • Display aggregated reactions on timeline items
  • React on a particular timeline item through the contextual menu
  • Display the full list of supported emoji reactions

Designs here https://www.figma.com/file/urDzUwqbnLNuXmqg7hYB83/Element-X-%5BEX1%5D?node-id=1586%3A60504&t=0ajj3ypCxcYEMFQ7-0

Screenshot 2022-11-21 at 11 39 58

@stefanceriu stefanceriu added Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-User-Story labels Jun 29, 2022
@stefanceriu stefanceriu added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Oct 19, 2022
@stefanceriu
Copy link
Member Author

Reactions are now supported with the following caveats:

  • there's a "Reactions" context menu option that brings up a sheet. This is because adding a custom view to a context menu is close to impossible. Doing that will require us building our own custom context menu which we would like to avoid
  • the same sheet can be brough up by double tapping a timeline item
  • no way to tell which reactions are yours
  • cannot redact a reaction
  • no local echo for reactions

Let's close this ticket for npw and follow up separately later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

No branches or pull requests

2 participants