Require a specific snapshotting device minor OS version when running …

…PreviewTests
element-hq · Sep 11, 2024 · 84a3ffc · 84a3ffc
1 parent 65bacfa
commit 84a3ffc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/PreviewTests/Sources/PreviewTests.swift b/PreviewTests/Sources/PreviewTests.swift
@@ -15,7 +15,7 @@ import SwiftUI
 class PreviewTests: XCTestCase {
     private let deviceConfig: ViewImageConfig = .iPhoneX
     private var simulatorDevice: String? = "iPhone14,6" // iPhone SE 3rd Generation
-    private var requiredOSVersion: Int? = 17
+    private var requiredOSVersion = (major: 17, minor: 5)
     private let snapshotDevices = ["iPhone 15", "iPad"]
 
     override func setUp() {
@@ -1084,11 +1084,9 @@ class PreviewTests: XCTestCase {
             }
         }
 
-        if let requiredOSVersion {
-            let osVersion = ProcessInfo().operatingSystemVersion
-            guard osVersion.majorVersion == requiredOSVersion else {
-                fatalError("Switch to iOS \(requiredOSVersion) for these tests.")
-            }
+        let osVersion = ProcessInfo().operatingSystemVersion
+        guard osVersion.majorVersion == requiredOSVersion.major, osVersion.minorVersion == requiredOSVersion.minor else {
+            fatalError("Switch to iOS \(requiredOSVersion) for these tests.")
         }
     }
 }

diff --git a/Tools/Sourcery/PreviewTests.stencil b/Tools/Sourcery/PreviewTests.stencil
@@ -25,7 +25,7 @@ import {{ import }}
 class PreviewTests: XCTestCase {
     private let deviceConfig: ViewImageConfig = .iPhoneX
     private var simulatorDevice: String? = "iPhone14,6" // iPhone SE 3rd Generation
-    private var requiredOSVersion: Int? = 17
+    private var requiredOSVersion = (major: 17, minor: 5)
     private let snapshotDevices = ["iPhone 15", "iPad"]
 
 
@@ -163,11 +163,9 @@ class PreviewTests: XCTestCase {
             }
         }
 
-        if let requiredOSVersion {
-            let osVersion = ProcessInfo().operatingSystemVersion
-            guard osVersion.majorVersion == requiredOSVersion else {
-                fatalError("Switch to iOS \(requiredOSVersion) for these tests.")
-            }
+        let osVersion = ProcessInfo().operatingSystemVersion
+        guard osVersion.majorVersion == requiredOSVersion.major, osVersion.minorVersion == requiredOSVersion.minor else {
+            fatalError("Switch to iOS \(requiredOSVersion) for these tests.")
         }
     }
 }